Passed Run of Nov 8, 09:03
pytest --flakytest-profile --flakytest-rate 2000.
Where the time goes
Test time by category- Password hashing26.73 s
- Migrations25.25 s
- Libraries17.17 s
- Database13.66 s
- Templates3.03 s
- DB schema2.59 s
- Imports1.71 s
- Mocking1.49 s
- Unsampled525 ms
- pytest434 ms
- Factories364 ms
- App code111 ms
- Deep copies75 ms
- Test code51 ms
- Waiting32 ms
- Network28 ms
- Logging22 ms
- Cache17 ms
- Serialization14 ms
Session timeline
Fix next
Ranked by the time each fix saves per runUse plain static file storage in tests
Static file storage/manifest handling costs 26.2s.
Details
Where:
- accounts/views.py:425 index · 924 ms
- starter_packs/views.py:862 share_starter_pack · 660 ms
- confs/views.py:509 create_conference · 596 ms
- accounts/tests.py:550 TestAccountIndexRobots.assert_noindex · 564 ms
- starter_packs/views.py:185 starter_packs · 492 ms
- starter_packs/tests.py:781 TestShareStarterPack.test_order_by · 484 ms
- starter_packs/views.py:858 share_starter_pack · 472 ms
- starter_packs/tests.py:841 TestShareStarterPack.test_api_formats · 441 ms
- confs/tests.py:1067 TestCreateConference.test_form_renders_for_authenticated_user · 358 ms
- confs/views.py:296 _conference_detail · 322 ms
Most affected tests:
- confs/tests.py::TestCreateConference::test_form_renders_for_authenticated_user
- accounts/tests.py::TestSelectedInstance::test_invalid_selected_instance
- starter_packs/tests.py::TestShareStarterPack::test_share_starter_pack
- starter_packs/tests.py::TestShareStarterPack::test_languages_hidden_when_unset
- accounts/tests.py::TestAccountIndexRobots::test_two_facets_are_noindex
- confs/tests.py::TestConferencePage::test_conference_with_utc_with_date_no_posts
- confs/tests.py::TestCreateConference::test_rejects_more_than_three_icons
- accounts/tests.py::TestAccountIndexRobots::test_single_facet_is_indexable
Use a fast password hasher in tests
26.7s (29% of test time) is spent hashing passwords. Slow hashing protects real passwords; in tests it only burns CPU.
Details
Only change the hasher in test settings. Tests that assert on a specific hash format need updating.
Where:
- confs/tests.py:1044 TestCreateConference.setUp · 4.48 s
- confs/tests.py:1175 TestEditConference.setUp · 4.07 s
- confs/tests.py:1177 TestEditConference.setUp · 3.78 s
- confs/tests.py:1176 TestEditConference.setUp · 3.36 s
- confs/tests.py:1371 TestApproveConference.setUp · 2.98 s
- confs/tests.py:1372 TestApproveConference.setUp · 2.67 s
- confs/tests.py:1316 TestConferenceApprovalVisibility.setUp · 1.51 s
- confs/tests.py:1317 TestConferenceApprovalVisibility.setUp · 1.50 s
- confs/tests.py:1295 TestUnapproveConference.setUp · 612 ms
- fedidevs/tests.py:63 TestAnonymousCacheAndCsrf.test_authenticated_html_is_private_and_keeps_csrf_header · 599 ms
Most affected tests:
- confs/tests.py::TestEditConference::test_owner_can_edit
- confs/tests.py::TestEditConference::test_edit_does_not_change_slug
- confs/tests.py::TestEditConference::test_other_user_forbidden
- confs/tests.py::TestEditConference::test_other_user_forbidden_on_approved_conference
- fedidevs/tests.py::TestAnonymousCacheAndCsrf::test_authenticated_html_is_private_and_keeps_csrf_header
- confs/tests.py::TestEditConference::test_owner_can_edit_after_approval
- confs/tests.py::TestApproveConference::test_get_not_allowed
- confs/tests.py::TestApproveConference::test_staff_approves
Stop re-running migrations on every test run
Migrations take 25.3s per run, before the first test can start.
Details
CI should still build the database from scratch (no --reuse-db) so broken migrations are caught.
Where:
- confs/tests.py:432 TestLegacyConferenceDataMigration._migrate · 1.25 s
- confs/migrations/0031_seed_conference_tags.py:14 seed_conference_tags · 787 ms
- confs/tests.py:412 TestLegacyConferenceDataMigration._leaf_targets · 136 ms
- confs/migrations/0033_remove_legacy_conference_tables.py:388 _get_or_create_conference · 87 ms
- confs/migrations/0033_remove_legacy_conference_tables.py:325 _refresh_account_counts · 86 ms
- confs/migrations/0033_remove_legacy_conference_tables.py:214 _pk_batches · 78 ms
- confs/tests.py:430 TestLegacyConferenceDataMigration._migrate · 71 ms
- confs/tests.py:431 TestLegacyConferenceDataMigration._migrate · 58 ms
- confs/migrations/0033_remove_legacy_conference_tables.py:398 migrate_legacy_pair · 48 ms
- confs/tests.py:486 TestLegacyConferenceDataMigration._seed_overlapping_legacy_data · 46 ms
Most affected tests:
- accounts/tests.py::TestAccountIndexRobots::test_two_facets_are_noindex
- accounts/tests.py::TestSelectedInstance::test_invalid_selected_instance
- confs/tests.py::TestSyncAnnouncements::test_is_idempotent_and_refreshes_unposted_content
- confs/tests.py::TestMigratedLegacyConferences::test_fwd50_date_redirects
- confs/tests.py::TestLegacyConferenceDataMigration::test_copies_overlapping_legacy_rows_without_clobbering_existing_data
- confs/tests.py::TestLegacyConferenceDataMigration::test_drops_legacy_tables_when_uniques_are_mysql_style_indexes
Create shared test data in setUpTestData instead of setUp
setUp() runs before every test and takes 25.8s in total (password hashing 25.6s, db 215ms, factories 6ms) in 7 classes: TestPostAnnouncements (6 tests), TestFollowStarterPack (3 tests), TestApproveConference (6 tests), TestCreateConference (10 tests).
Details
Since Django 3.2 attributes assigned in setUpTestData are deep-copied per test, so in-memory changes don't leak between tests. Keep objects a test modifies in the database (or re-fetches) as before.
Where:
- confs/tests.py:1044 TestCreateConference.setUp · 4.50 s
- confs/tests.py:1175 TestEditConference.setUp · 4.08 s
- confs/tests.py:1177 TestEditConference.setUp · 3.79 s
- confs/tests.py:1176 TestEditConference.setUp · 3.37 s
- confs/tests.py:1371 TestApproveConference.setUp · 2.99 s
- confs/tests.py:1372 TestApproveConference.setUp · 2.68 s
- confs/tests.py:1316 TestConferenceApprovalVisibility.setUp · 1.52 s
- confs/tests.py:1317 TestConferenceApprovalVisibility.setUp · 1.51 s
- confs/tests.py:1295 TestUnapproveConference.setUp · 615 ms
- confs/tests.py:1296 TestUnapproveConference.setUp · 600 ms
Most affected tests:
- confs/tests.py::TestEditConference::test_owner_can_edit
- confs/tests.py::TestEditConference::test_edit_does_not_change_slug
- confs/tests.py::TestEditConference::test_other_user_forbidden
- confs/tests.py::TestEditConference::test_other_user_forbidden_on_approved_conference
- confs/tests.py::TestEditConference::test_owner_can_edit_after_approval
- confs/tests.py::TestApproveConference::test_get_not_allowed
- confs/tests.py::TestApproveConference::test_staff_approves
- confs/tests.py::TestApproveConference::test_non_staff_forbidden
Disable django-debug-toolbar in tests
django-debug-toolbar is installed in the test settings and costs 11.0s.
Details
Where:
- accounts/views.py:425 index · 924 ms
- starter_packs/views.py:862 share_starter_pack · 660 ms
- confs/views.py:509 create_conference · 596 ms
- starter_packs/views.py:185 starter_packs · 492 ms
- starter_packs/views.py:858 share_starter_pack · 472 ms
- confs/views.py:296 _conference_detail · 322 ms
- starter_packs/views.py:60 get_editable_pack · 280 ms
- accounts/templatetags/account_extras.py:36 instances_datalist · 243 ms
- confs/views.py:276 _conference_detail.<locals>.<genexpr> · 227 ms
- confs/views.py:128 conferences · 225 ms
Most affected tests:
- confs/tests.py::TestCreateConference::test_form_renders_for_authenticated_user
- starter_packs/tests.py::TestShareStarterPack::test_languages_hidden_when_unset
- accounts/tests.py::TestSelectedInstance::test_invalid_selected_instance
- accounts/tests.py::TestAccountIndexRobots::test_single_facet_is_indexable
- fedidevs/tests.py::TestAnonymousCacheAndCsrf::test_anonymous_forms_work_after_csrf_bootstrap
- confs/tests.py::TestMigratedLegacyConferences::test_fwd50_page
- starter_packs/tests.py::TestPinAccountInStarterPack::test_pin_button_shown_on_review_page
- accounts/tests.py::TestStaticPages::test_developers_on_mastodon
Repeated queries (N+1) in the code under test
10 tests run the same query 10+ times, e.g. 45x in test_two_facets_are_noindex. N+1 queries slow the tests and production alike.
Details
This changes application code, so it speeds up production too; the tests stay as they are.
- 45x in test_two_facets_are_noindex: SELECT "confs_conferencetag"."id", "confs_conferencetag"."name", "confs_conferencetag"."slug", "confs_conferencetag"."icon" FROM "confs_conferencetag" WHERE "confs_conferencetag"."slug" = %s LIMIT ? FOR UPDATE
- 45x in test_invalid_selected_instance: SELECT "confs_conferencetag"."id", "confs_conferencetag"."name", "confs_conferencetag"."slug", "confs_conferencetag"."icon" FROM "confs_conferencetag" WHERE "confs_conferencetag"."slug" = %s LIMIT ? FOR UPDATE
- 45x in test_fwd50_date_redirects: SELECT "confs_conferencetag"."id", "confs_conferencetag"."name", "confs_conferencetag"."slug", "confs_conferencetag"."icon" FROM "confs_conferencetag" WHERE "confs_conferencetag"."slug" = %s LIMIT ? FOR UPDATE
- 45x in test_is_idempotent_and_refreshes_unposted_content: SELECT "confs_conferencetag"."id", "confs_conferencetag"."name", "confs_conferencetag"."slug", "confs_conferencetag"."icon" FROM "confs_conferencetag" WHERE "confs_conferencetag"."slug" = %s LIMIT ? FOR UPDATE
- 44x in test_posts_from_yesterday_are_updated: SELECT COUNT(*) AS "__count" FROM "accounts_accountlookup" WHERE UPPER("accounts_accountlookup"."language"::text) LIKE UPPER(%s)
Most affected tests:
- accounts/tests.py::TestAccountIndexRobots::test_two_facets_are_noindex
- accounts/tests.py::TestSelectedInstance::test_invalid_selected_instance
- confs/tests.py::TestMigratedLegacyConferences::test_fwd50_date_redirects
- confs/tests.py::TestSyncAnnouncements::test_is_idempotent_and_refreshes_unposted_content
- stats/tests.py::TestStats::test_posts_from_yesterday_are_updated
- stats/tests.py::TestStats::test_store_daily_stats
- stats/tests.py::TestStats::test_store_daily_stats_with_accounts
- accounts/tests.py::TestInstanceIndexingBridgy::test_follows_redirect_and_coerces_null_version
Make the test database server skip durability work
Tests spend 41.5s (44%) in the database. Test databases don't need to survive a crash, so the server can skip flushing to disk.
Details
Only affects crash safety of the throwaway test server; query behaviour is identical.
Where:
- confs/tests.py:432 TestLegacyConferenceDataMigration._migrate · 1.25 s
- confs/migrations/0031_seed_conference_tags.py:14 seed_conference_tags · 787 ms
- starter_packs/tests.py:397 TestToggleStarterPackAccount.test_toggle_after_limit · 682 ms
- starter_packs/views.py:858 share_starter_pack · 472 ms
- starter_packs/views.py:60 get_editable_pack · 280 ms
- accounts/templatetags/account_extras.py:36 instances_datalist · 243 ms
- confs/views.py:276 _conference_detail.<locals>.<genexpr> · 227 ms
- stats/models.py:20 store_daily_stats · 207 ms
- accounts/views.py:295 index · 202 ms
- starter_packs/views.py:856 share_starter_pack · 186 ms
Most affected tests:
- accounts/tests.py::TestSelectedInstance::test_invalid_selected_instance
- confs/tests.py::TestSyncAnnouncements::test_is_idempotent_and_refreshes_unposted_content
- accounts/tests.py::TestAccountIndexRobots::test_two_facets_are_noindex
- confs/tests.py::TestMigratedLegacyConferences::test_fwd50_date_redirects
- confs/tests.py::TestLegacyConferenceDataMigration::test_copies_overlapping_legacy_rows_without_clobbering_existing_data
- confs/tests.py::TestLegacyConferenceDataMigration::test_drops_legacy_tables_when_uniques_are_mysql_style_indexes
- starter_packs/tests.py::TestToggleStarterPackAccount::test_toggle_after_limit
- accounts/tests.py::TestInstanceIndexingBridgy::test_follows_redirect_and_coerces_null_version
pytest-xdist workers finish at very different times
The busiest worker ran 31.3s of tests, the least busy 20.2s.
Details
pytest takes a long time before the first test runs
Startup takes 8.4s and collection 2.9s on every run, even when you only run one test.
Details
- mastodon_auth/tests.py (1.1s)
- starter_packs/tests.py (276ms)
- accounts/tests.py (62ms)
- confs/tests.py (19ms)
- stats/tests.py (3ms)
- fedidevs/settings.py (1.9s)
- debug_toolbar/panels/sql/__init__.py (1.2s)
- starter_packs/admin.py (735ms)
Run migrations once, not once per worker
Each of the 4 pytest-xdist workers builds its own test database by running every migration: 25.5s in total, about 6.4s per worker. 19.1s of it repeats work another worker already did.
Details
Every copy is built by the same migrations, so a broken migration still fails the run.
- {'total': 25.485, 'builds': 4, 'workers': 4, 'per_build': 6.371}
Tests
201–310 of 310, slowest first · click a column to sort this pageMemory
Busiest worker peaked at 211 MB; all 4 together at about 652 MB| Worker | Tests | Peak | Grew by |
|---|---|---|---|
| gw0 | 127 | 203 MB | 57 MB |
| gw1 | 96 | 189 MB | 45 MB |
| gw2 | 52 | 211 MB | 41 MB |
| gw3 | 35 | 183 MB | 42 MB |
Slowest fixtures
Exact setup time across the session| Fixture | Scope | Calls | Total |
|---|---|---|---|
| _django_setup_unittest | class | 75 | 25.53 s |
| django_db_setup | session | 4 | 25.49 s |
| _unittest_setUpClass_fixture_TestShareStarterPack | class | 2 | 181 ms |
| _unittest_setUpClass_fixture_TestSelectedInstance | class | 1 | 161 ms |
| _unittest_setUpClass_fixture_TestPinAccountInStarterPack | class | 2 | 125 ms |
| _unittest_setUpClass_fixture_TestWebfingerBackfill | class | 1 | 101 ms |
| _unittest_setUpClass_fixture_TestOwnerManagement | class | 2 | 99 ms |
| _unittest_setUpClass_fixture_TestDeleteStarterPack | class | 2 | 85 ms |
| _unittest_setUpClass_fixture_TestFollowBg | class | 1 | 72 ms |
| _unittest_setUpClass_fixture_TestRemoteFollowStarterPack | class | 2 | 57 ms |
| _unittest_setUpClass_fixture_TestFollowStarterPack | class | 1 | 55 ms |
| _unittest_setUpClass_fixture_TestAddAccountsSearch | class | 1 | 43 ms |
| _unittest_setUpClass_fixture_TestStarterPacks | class | 1 | 42 ms |
| _unittest_setUpClass_fixture_TestEditStarterPack | class | 1 | 42 ms |
| _unittest_setUpClass_fixture_TestToggleStarterPackAccount | class | 1 | 41 ms |